Skip to content

Commit

Permalink
chore(packaging): do not add engine instruction to package.json (#2198)
Browse files Browse the repository at this point in the history 
This then warns user installing via npm about their engine not being compatible.
  • Loading branch information
@vvo @bobylito
vvo authored and bobylito committed Jun 16, 2017
1 parent 7e68b51 commit 95c6bf1
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,6 @@
"dist",
"dist-es5-module"
],
"engines": {
"node": "7.10.0"
},
"devDependencies": {
"autoprefixer": "^6.7.6",
"babel-cli": "^6.23.0",
Expand Down

1 comment on commit 95c6bf1

@vvo
Copy link
Contributor Author

@vvo vvo commented on 95c6bf1 Jun 19, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @Shipow that's what was preventing you to build on netlify. when using NODE_ENV=production then npm will check for the exact engine.

We removed it but it needs a new release, I am unsure we can do one @bobylito is v1 of the project OK to be released?

Please sign in to comment.