Merge pull request #109 from algolia/fix/get-container-node-error

fix: More explicit error message when DOM selector is invalid
algolia · Sep 22, 2015 · 5ebfe75 · 5ebfe75
2 parents d84af23 + d36a2ad
commit 5ebfe75
Showing 1 changed file with 13 additions and 5 deletions.
diff --git a/lib/utils.js b/lib/utils.js
@@ -1,13 +1,21 @@
 function getContainerNode(selectorOrHTMLElement) {
-  if (typeof selectorOrHTMLElement === 'string') {
-    return document.querySelector(selectorOrHTMLElement);
+  var isFromString = (typeof selectorOrHTMLElement === 'string');
+  var domElement;
+  if (isFromString) {
+    domElement = document.querySelector(selectorOrHTMLElement);
+  } else {
+    domElement = selectorOrHTMLElement;
   }
 
-  if (!isDomElement(selectorOrHTMLElement)) {
-    throw new Error('Container must be `string` or `HTMLElement`');
+  if (!isDomElement(domElement)) {
+    var errorMessage = 'Container must be `string` or `HTMLElement`.';
+    if (isFromString) {
+      errorMessage += ' Unable to find ' + selectorOrHTMLElement;
+    }
+    throw new Error(errorMessage);
   }
 
-  return selectorOrHTMLElement;
+  return domElement;
 }
 
 function isDomElement(o) {