Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Programmatically updating the query will not update the searchbox #803

Closed
vvo opened this issue Jan 29, 2016 · 1 comment · Fixed by #886
Closed

Programmatically updating the query will not update the searchbox #803

vvo opened this issue Jan 29, 2016 · 1 comment · Fixed by #886
Assignees
Milestone

Comments

@vvo
Copy link
Contributor

vvo commented Jan 29, 2016

Should we provide an option or handle it by default?

There have been usecases report lately about this and the workaround was not only to change the helper query but also update the DOM element manually (which is hacky and may result in multiple searches?)

@bobylito
Copy link
Contributor

From an implementation POV, it's a bit sad that the searchbox does not update itself when the query of the SearchParameters is updated. Have we tried with the latest version with the urlsync fix?

@vvo vvo added the Type: Bug label Feb 1, 2016
@vvo vvo self-assigned this Feb 1, 2016
@vvo vvo added this to the 1.3 milestone Feb 2, 2016
vvo pushed a commit that referenced this issue Mar 1, 2016
@vvo vvo closed this as completed in 6a0af14 Mar 4, 2016
vvo pushed a commit that referenced this issue Mar 4, 2016
<a name="1.3.0"></a>
# [1.3.0](v1.2.5...v1.3.0) (2016-03-04)

### Bug Fixes

* **browser support:** make IE lte 10 work by fixing Object.getPrototypeOf ([bbb264b](bbb264b))
* **menu,refinementList:** sort by count AND name to avoid reorders on refine ([02fe7bf](02fe7bf)), closes [#65](#65)
* **priceRanges:** pass the bound refine to the form ([ce2b956](ce2b956))
* **searchBox:** handle external updates of the query ([6a0af14](6a0af14)), closes [#803](#803)
* **searchBox:** stop setting the query twice ([91270b2](91270b2))
* **searchBox:** stop updating query at eachkeystroke with searchOnEnterKeyPressOnly ([28dc4d2](28dc4d2)), closes [#875](#875)
* **Slider:** do not render Slider when range.min === range.max ([f20274e](f20274e))
* **Template:** now render() when templateKey changes ([8906224](8906224))
* **toggle:** pass isRefined to toggleRefinement ([8ac494e](8ac494e))
* **url-sync:** always decode incoming query string ([bea38e3](bea38e3)), closes [#848](#848)
* **url-sync:** handle <base> href pages ([e58aadc](e58aadc)), closes [#790](#790)

### Features

* **collapsable widgets:** add collapsable and collapsed option ([c4df7c5](c4df7c5))
* **instantsearch:** allow overriding the helper.search function ([9a930e7](9a930e7))
* **rangeSlider:** allow passing min and max values ([409295c](409295c)), closes [#858](#858)
* **searchBox:** allow to pass a queryHook ([5786a64](5786a64))
* **Template:** allow template functions to return a React element ([748077d](748077d))
* **Template:** allow template functions to return a React element ([0f9296d](0f9296d))

### Performance Improvements

* **autoHideContainer:** stop re-creating React components ([8c89862](8c89862))
* **formatting numbers:** stop using a default locale, use the system one ([b056554](b056554))
* **nouislider:** upgrade nouislider, shaves some more ms ([fefbe65](fefbe65))
* **React:** use babel `optimisation` option for React ([95f940c](95f940c))
* **React, widgets:** implement shouldComponentUpdate, reduce bind ([5efaac1](5efaac1))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants