fix(types): improve UiState types #3763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
Haroenv
reviewed
May 7, 2019
|
Deploy preview for instantsearchjs ready! Built with commit 273f69a |
Haroenv
approved these changes
May 13, 2019
eunjae-lee
pushed a commit
that referenced
this pull request
May 14, 2019
# [3.5.0](v3.4.0...v3.5.0) (2019-05-14) ### Bug Fixes * **hitsPerPage:** improve warning for missing state value ([#3707](#3707)) ([93d8432](93d8432)) * **numericMenu:** prevent refinement reset on checked radio click ([#3749](#3749)) ([e4a6e75](e4a6e75)) * **rangeSlider:** round the slider pit value ([#3758](#3758)) ([6edee3e](6edee3e)), closes [#2904](#2904) * **types:** improve UiState types ([#3763](#3763)) ([e8ea57b](e8ea57b)) * **voice:** import correct noop ([#3766](#3766)) ([6a80422](6a80422)) ### Features * **voiceSearch:** add connector and widget ([#3601](#3601)) ([21e4d81](21e4d81))
samouss
reviewed
May 14, 2019
| refinementList?: { | ||
| [attribute: string]: string[]; | ||
| }; | ||
| numericRefinementList?: { |
There was a problem hiding this comment.
We don't have a numericRefinementList widget.
| range?: { | ||
| [attribute: string]: string; | ||
| }; | ||
| starRating?: { |
There was a problem hiding this comment.
The name is ratingMenu not starRating.
| @@ -31,7 +31,45 @@ interface DisposeOptions { | |||
| } | |||
|
|
|||
| export type UiState = { | |||
There was a problem hiding this comment.
The type does not contain: geoSearch, numericMenu.
| numericRefinementList?: { | ||
| [attribute: string]: number; | ||
| }; | ||
| numericSelector?: { |
There was a problem hiding this comment.
We don't have a numericSelector widget.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds types for the UI state.