fix(tools): use commonjs in bump-package-version.js #3699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems before 9296639 the script was run in developement env with no modules setting, which mean it defaulted to the poorly documented `auto`. Looking at their codebase it seems `auto` is simply `commonjs`. This explains why it worked before. We could have used BABEL_ENV=cjs in front of the babel-node command but I've moved this file to cjs as it's more simple and is consistent with other release scripts.
tkrugg
force-pushed
the
fix/commonjs-in-bump-package-version
branch
from
77ecc56
to
199b9f0
Compare
|
Deploy preview for instantsearchjs ready! Built with commit 77ecc56 |
francoischalifour
requested changes
Apr 16, 2019
There was a problem hiding this comment.
We can remove babel-node (@babel/node) all together. It was introduced in 453dc21.
|
Deploy preview for instantsearchjs ready! Built with commit f5e1437 |
francoischalifour
approved these changes
Apr 16, 2019
tkrugg
added a commit
that referenced
this pull request
Apr 17, 2019
# [3.4.0](v3.3.0...v3.4.0) (2019-04-17) ### Bug Fixes * **storybook:** fix Hierarchical menu separator in Breadcrumb story ([#3695](#3695)) ([b3bf8ac](b3bf8ac)) * **tools:** use commonjs in bump-package-version.js ([#3699](#3699)) ([6a6dbe1](6a6dbe1)) * **types:** fix wrong typing in getWidgetState ([#3693](#3693)) ([b3c2154](b3c2154)) * **types:** remove unused Without type ([#3694](#3694)) ([656d000](656d000)) ### Features * **infiniteHits:** add previous button ([#3675](#3675)) ([2e6137b](2e6137b)) * **Insights:** Insights inside Instantsearch ([#3598](#3598)) ([387f41f](387f41f))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It seems before 9296639 the script was run in developement env with no modules setting, which mean it defaulted to the poorly documented
auto. https://babeljs.io/docs/en/babel-preset-env#modulesLooking at their codebase it seems
autois simplycommonjs. This explains why it worked before.https://github.com/babel/babel/blob/8ca99b9f0938daa6a7d91df81e612a1a24b09d98/packages/babel-preset-env/src/module-transformations.js#L6
We could have used BABEL_ENV=cjs in front of the babel-node command but
I've moved this file to cjs as it's more simple and is consistent with
other release scripts.