fix(normalizeRefinement): remove boolean values passed to _objectSpread in normalizeRefinement
#3672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkrugg
force-pushed
the
fix/normalize-refinements
branch
from
20301b4
to
705887f
Compare
|
Deploy preview for instantsearchjs ready! Built with commit 2beeadb |
samouss
approved these changes
Apr 9, 2019
tkrugg
force-pushed
the
fix/normalize-refinements
branch
from
705887f
to
b397af8
Compare
tkrugg
changed the title
_objectSpread in normalizeRefinement_objectSpread in normalizeRefinement
Haroenv
approved these changes
Apr 9, 2019
francoischalifour
approved these changes
Apr 10, 2019
yannickcr
approved these changes
Apr 10, 2019
…ad in normalizeRefinement _objectSpread polyfill calls Object.keys() under the hood which on IE11 does not support anything other than objects. Reason: change in spec ES5: https://www.ecma-international.org/ecma-262/5.1/#sec-15.2.3.14 > If the Type(O) is not Object, throw a TypeError exception. ES6: https://www.ecma-international.org/ecma-262/6.0/#sec-object.keys Uses ToObject, which supports booleans > Return a new Boolean object whose [[BooleanData]] internal slot is set to the value of argument. See 19.3 for a description of Boolean objects
tkrugg
force-pushed
the
fix/normalize-refinements
branch
from
6c24b97
to
f130a95
Compare
francoischalifour
added a commit
that referenced
this pull request
Apr 11, 2019
# [3.3.0](v3.2.1...v3.3.0) (2019-04-11) ### Bug Fixes * **connectQueryRules:** improve tracked refinement type ([#3648](#3648)) ([e16ad57](e16ad57)) * **currentRefinements:** don't rely on ([#3672](#3672)) ([cd64bcf](cd64bcf)) * **queryRuleCustomData:** add default template ([#3650](#3650)) ([83e9eaa](83e9eaa)) * **QueryRuleCustomData:** pass data as object to templates ([#3647](#3647)) ([b8f8b4e](b8f8b4e)) * **queryRules:** fix types and stories ([#3670](#3670)) ([ba6e2e6](ba6e2e6)) * **routing:** apply windowTitle on first load ([#3669](#3669)) ([d553502](d553502)), closes [#3667](#3667) * **routing:** support parsing URLs with up to 100 refinements ([#3671](#3671)) ([6ddcfb6](6ddcfb6)) * **RoutingManager:** avoid stale uiState ([#3630](#3630)) ([e1588aa](e1588aa)) * **types:** improve InstantSearch types ([#3651](#3651)) ([db9b91e](db9b91e)) * **ua:** Update the User-Agent to use the new format ([#3616](#3616)) ([ab84c57](ab84c57)) ### Features * **infiniteHits:** add previous button ([#3645](#3645)) ([2c9e38d](2c9e38d)) * **queryRules:** add connectQueryRules connector ([#3597](#3597)) ([924cd99](924cd99)), closes [#3599](#3599) [#3600](#3600) * **queryRules:** add context features to Query Rules ([#3617](#3617)) ([922879e](922879e)), closes [#3602](#3602) ### Reverts * feat(infiniteHits): add previous button ([214c0fc](214c0fc))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
_objectSpread polyfill calls Object.keys() under the hood which on IE11
does not support anything other than objects.
Reason: change in spec
ES5: https://www.ecma-international.org/ecma-262/5.1/#sec-15.2.3.14
ES6: https://www.ecma-international.org/ecma-262/6.0/#sec-object.keys
Uses ToObject, which supports booleans
Result
No we are avoiding booleans altogether.
Nothing should change. I'll test this out in IE once it's deployed