Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(voiceSearch): add connector and widget #3601

Merged
merged 121 commits into from
Apr 29, 2019
Merged

Conversation

eunjae-lee
Copy link
Contributor

@eunjae-lee eunjae-lee commented Mar 13, 2019

This POC shows an implementation of voice search widget on instantsearch.js.
See more: https://github.com/algolia/instantsearch-rfcs/pull/15

This PR is a draft, not intended to be merged right away.

@algobot
Copy link
Contributor

algobot commented Mar 13, 2019

Deploy preview for instantsearchjs ready!

Built with commit 71a17e3

https://deploy-preview-3601--instantsearchjs.netlify.com

Copy link
Contributor

@tkrugg tkrugg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor things I noted but looking good.
It's cool to see this feature landing.

src/components/VoiceSearch/VoiceSearch.js Outdated Show resolved Hide resolved
src/components/VoiceSearch/VoiceSearch.js Outdated Show resolved Hide resolved
src/components/VoiceSearch/VoiceSearch.js Outdated Show resolved Hide resolved
src/connectors/voice-search/connectVoiceSearch.js Outdated Show resolved Hide resolved
src/connectors/voice-search/connectVoiceSearch.js Outdated Show resolved Hide resolved
Copy link
Member

@francoischalifour francoischalifour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the branch is updated we should be able to move forward with this.

src/connectors/voice-search/connectVoiceSearch.ts Outdated Show resolved Hide resolved
src/lib/voiceSearchHelper/index.ts Show resolved Hide resolved
@eunjae-lee eunjae-lee dismissed samouss’s stale review April 29, 2019 11:25

All the things are addressed now.

@eunjae-lee eunjae-lee merged commit 21e4d81 into develop Apr 29, 2019
eunjae-lee pushed a commit that referenced this pull request May 14, 2019
# [3.5.0](v3.4.0...v3.5.0) (2019-05-14)

### Bug Fixes

* **hitsPerPage:** improve warning for missing state value ([#3707](#3707)) ([93d8432](93d8432))
* **numericMenu:** prevent refinement reset on checked radio click ([#3749](#3749)) ([e4a6e75](e4a6e75))
* **rangeSlider:** round the slider pit value ([#3758](#3758)) ([6edee3e](6edee3e)), closes [#2904](#2904)
* **types:** improve UiState types ([#3763](#3763)) ([e8ea57b](e8ea57b))
* **voice:** import correct noop ([#3766](#3766)) ([6a80422](6a80422))

### Features

* **voiceSearch:** add connector and widget ([#3601](#3601)) ([21e4d81](21e4d81))
@Haroenv Haroenv deleted the poc/voice-search branch September 24, 2019 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants