Avoid to always round the range in connectRange #2498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview ready! Built with commit 9df4656 https://deploy-preview-2498--algolia-instantsearch.netlify.com |
bobylito
reviewed
Oct 18, 2017
src/connectors/range/connectRange.js
Outdated
| @@ -100,8 +100,8 @@ export default function connectRange(renderFn) { | |||
| } | |||
|
|
|||
| return { | |||
| min: Math.floor(min), | |||
| max: Math.ceil(max), | |||
| min: precision === 0 ? Math.floor(min) : min, | |||
There was a problem hiding this comment.
What does it mean for a precision of 1 and there 3 digits after the . or ,? Wouldn't it be more consistent if we were to apply the same logic based on precision?
There was a problem hiding this comment.
When I begin to implement it, I thought it was a bit overkill so I remove it.
There was a problem hiding this comment.
Well Isn't the purpose to bring consistency? And in this case, we only have consistency for precision = 0, right?
There was a problem hiding this comment.
But then I might not have a good idea of the complexity...
There was a problem hiding this comment.
Right, I will update it 🙃
iam4x
approved these changes
Oct 18, 2017
iam4x
added a commit
that referenced
this pull request
Oct 24, 2017
<a name=2.3.0-beta.2></a> # [2.3.0-beta.2](v2.2.1...v2.3.0-beta.2) (2017-10-24) ### Bug Fixes * **connectHierarchicalMenu:** do not return if facet not set ([#2521](#2521)) ([26e99fb](26e99fb)) * **MenuSelect:** switch from react to preact-compat ([#2513](#2513)) ([06aa626](06aa626)) * **range-slider:** add option ([#2502](#2502)) ([e78399d](e78399d)), closes [#2501](#2501) ### Features * **breadcrumb:** Add the breadcrumb widget ([#2451](#2451)) ([11d78f0](11d78f0)), closes [#2299](#2299) * **connectRange:** round the range based on precision ([#2498](#2498)) ([d4df45d](d4df45d)) * **rangeInput:** add rangeInput widget ([#2440](#2440)) ([7916d16](7916d16))
bobylito
pushed a commit
that referenced
this pull request
Nov 13, 2017
<a name=2.3.0-beta.4></a> # [2.3.0-beta.4](v2.2.4...v2.3.0-beta.4) (2017-11-13) ### Features * **core:** InstantSearch hot remove/add widgets ([#2384](#2384)) ([cfc1710](cfc1710)) <a name=2.3.0-beta.3></a> # [2.3.0-beta.3](v2.3.0-beta.2...v2.3.0-beta.3) (2017-10-25) ### Bug Fixes * **connectors:** export as well ([0b78d75](0b78d75)) ### Features * **refinementList:** add escapeFacetHits parameter ([#2507](#2507)) ([9b1b7ee](9b1b7ee)) <a name=2.3.0-beta.2></a> # [2.3.0-beta.2](v2.2.1...v2.3.0-beta.2) (2017-10-24) ### Bug Fixes * **connectHierarchicalMenu:** do not return if facet not set ([#2521](#2521)) ([26e99fb](26e99fb)) ### Features * **breadcrumb:** Add the breadcrumb widget ([#2451](#2451)) ([11d78f0](11d78f0)), closes [#2299](#2299) * **connectRange:** round the range based on precision ([#2498](#2498)) ([d4df45d](d4df45d)) * **rangeInput:** add rangeInput widget ([#2440](#2440)) ([7916d16](7916d16))
bobylito
pushed a commit
that referenced
this pull request
Nov 16, 2017
<a name=2.3.0-beta.5></a> # [2.3.0-beta.5](v2.2.4...v2.3.0-beta.5) (2017-11-16) ### Features * **core:** InstantSearch hot remove/add widgets ([#2384](#2384)) ([cfc1710](cfc1710)) <a name=2.3.0-beta.3></a> # [2.3.0-beta.3](v2.3.0-beta.2...v2.3.0-beta.3) (2017-10-25) ### Bug Fixes * **connectors:** export as well ([0b78d75](0b78d75)) ### Features * **refinementList:** add escapeFacetHits parameter ([#2507](#2507)) ([9b1b7ee](9b1b7ee)) <a name=2.3.0-beta.2></a> # [2.3.0-beta.2](v2.2.1...v2.3.0-beta.2) (2017-10-24) ### Bug Fixes * **connectHierarchicalMenu:** do not return if facet not set ([#2521](#2521)) ([26e99fb](26e99fb)) ### Features * **breadcrumb:** Add the breadcrumb widget ([#2451](#2451)) ([11d78f0](11d78f0)), closes [#2299](#2299) * **connectRange:** round the range based on precision ([#2498](#2498)) ([d4df45d](d4df45d)) * **rangeInput:** add rangeInput widget ([#2440](#2440)) ([7916d16](7916d16))
bobylito
pushed a commit
that referenced
this pull request
Nov 20, 2017
<a name=2.3.0-beta.7></a> # [2.3.0-beta.7](v2.2.5...v2.3.0-beta.7) (2017-11-20) <a name=2.3.0-beta.6></a> # [2.3.0-beta.6](v2.3.0-beta.5...v2.3.0-beta.6) (2017-11-16) ### Bug Fixes * **connectors:** prefer wrappers over bind ([#2575](#2575)) ([f8e0e00](f8e0e00)) <a name=2.3.0-beta.5></a> # [2.3.0-beta.5](v2.2.4...v2.3.0-beta.5) (2017-11-16) ### Features * **core:** InstantSearch hot remove/add widgets ([#2384](#2384)) ([cfc1710](cfc1710)) <a name=2.3.0-beta.3></a> # [2.3.0-beta.3](v2.3.0-beta.2...v2.3.0-beta.3) (2017-10-25) ### Bug Fixes * **connectors:** export as well ([0b78d75](0b78d75)) ### Features * **refinementList:** add escapeFacetHits parameter ([#2507](#2507)) ([9b1b7ee](9b1b7ee)) <a name=2.3.0-beta.2></a> # [2.3.0-beta.2](v2.2.1...v2.3.0-beta.2) (2017-10-24) ### Bug Fixes * **connectHierarchicalMenu:** do not return if facet not set ([#2521](#2521)) ([26e99fb](26e99fb)) ### Features * **breadcrumb:** Add the breadcrumb widget ([#2451](#2451)) ([11d78f0](11d78f0)), closes [#2299](#2299) * **connectRange:** round the range based on precision ([#2498](#2498)) ([d4df45d](d4df45d)) * **rangeInput:** add rangeInput widget ([#2440](#2440)) ([7916d16](7916d16))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In the
connectRangewe always round the range even with a precision greater than 0. Now we round the range only for a precision of 0 and leave the original value in the other case.Result
You can play with the
RangeInputon dev-novel.Before:
After: