Fix range slider pips and value 0 #2350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview ready! Built with commit 0dd17d3 https://deploy-preview-2350--algolia-instantsearch.netlify.com |
|
I have a question @iam4x , why does the header disappear when there is no pips? Is that a behaviour that we want? |
|
I just did not put a header on the second example, it's expected behaviour 👍 |
bobylito
previously requested changes
Sep 20, 2017
| expect(helper.getNumericRefinement('price', '<=')).toEqual([30]); | ||
| expect(helper.search.callCount).toBe(1); | ||
|
|
||
| refine([0, undefined]); |
There was a problem hiding this comment.
Just for the sake of being exhaustive, maybe we could try without the bounds. And also do the third case with [undefined, 20]
bobylito
approved these changes
Sep 20, 2017
bobylito
pushed a commit
that referenced
this pull request
Sep 25, 2017
<a name=2.1.5></a> ## [2.1.5](v2.1.4...v2.1.5) (2017-09-25) ### Bug Fixes * **deps:** update dependency algolia-frontend-components to v^0.0.33 ([#2341](#2341)) ([16994d8](16994d8)) * **price-ranges:** update call to refine ([#2377](#2377)) ([34915d7](34915d7)) * **slider:** Fix range slider pips and value 0 ([#2350](#2350)) ([fa0dc09](fa0dc09)), closes [#2343](#2343)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
pips: falseit was still showing pipsFixes #2343