Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(release-script): Add the generation of changelog for the release #2333

Merged
merged 4 commits into from
Sep 14, 2017

Conversation

bobylito
Copy link
Contributor

We forgot to add the changelog in the new release script. This PR also regen the changelog missing for some releases, and fix the commit validation (based on @rayrutjes suggestion)

Alex S added 3 commits September 13, 2017 14:27
The spec specifies that the scope is optional therefore we should not
enforce their use on the CI. However it is still a recommended practice
and we will enforce them when merging PRs.
@algobot
Copy link
Contributor

algobot commented Sep 14, 2017

Deploy preview ready!

Built with commit 67060f4

https://deploy-preview-2333--algolia-instantsearch.netlify.com

@bobylito bobylito requested review from iam4x and vvo and removed request for iam4x September 14, 2017 14:12
Copy link
Contributor

@iam4x iam4x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice 👍

@bobylito bobylito merged commit 9a2f70b into develop Sep 14, 2017
@bobylito bobylito deleted the fix/fix-changelog branch September 14, 2017 16:38
bobylito pushed a commit that referenced this pull request Sep 14, 2017
<a name=2.1.4></a>
## [2.1.4](v2.1.3...v2.1.4) (2017-09-14)

### Bug Fixes

* **release-script:** Add the generation of changelog for the release ([#2333](#2333)) ([9a2f70b](9a2f70b))
* **slider:** edge case when min > max ([#2336](#2336)) ([8830ab0](8830ab0))
* **slider:** Fix range slider dev env ([#2320](#2320)) ([e78de70](e78de70))
* **slider:** use algolia fork of rheostat ([#2335](#2335)) ([9eae009](9eae009))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants