Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When the number of facet values retrieved is less than the number to display, IS should hide the search input #2111

Closed
Jean-Edern opened this issue Apr 18, 2017 · 1 comment · Fixed by #2120
Closed

When the number of facet values retrieved is less than the number to display, IS should hide the search input #2111

Jean-Edern opened this issue Apr 18, 2017 · 1 comment · Fixed by #2120
Assignees
@bobylito
Labels
Difficulty: Easy Type: Bug

Comments

@Jean-Edern
Copy link

Not showing the "facet search text area" when the # of facets is less than the number being displayed (i.e. a facet returns 2 results, they are all displayed, and yet for some reason we still show the search to add more facets)

cc @seafoox
@bobylito
Copy link
Contributor

Good catch!

@bobylito bobylito changed the title Not displaying the facet search text area when all facets are shown When the number of facet values retrieved is less than the number to display, IS should hide the search input or show more Apr 19, 2017
@bobylito bobylito changed the title When the number of facet values retrieved is less than the number to display, IS should hide the search input or show more When the number of facet values retrieved is less than the number to display, IS should hide the search input Apr 20, 2017
bobylito pushed a commit that referenced this issue Apr 20, 2017
fix(sffv): disable sffv input when few facet values FIX #2111
a41c7c6 
When the number of items displayed in a refinement list is lower than
the max number of facet displayed, the search for facet input should be
disabled.

This fix disable the input and adds a new classname to identify the
state of the input.
@bobylito bobylito self-assigned this Apr 20, 2017
@bobylito bobylito mentioned this issue Apr 20, 2017
Merged
bobylito added a commit that referenced this issue Apr 20, 2017
@bobylito
fix(sffv): disable sffv input when few facet values FIX #2111
1e33c10 
When the number of items displayed in a refinement list is lower than
the max number of facet displayed, the search for facet input should be
disabled.

This fix disable the input and adds a new classname to identify the
state of the input.
bobylito pushed a commit that referenced this issue Apr 20, 2017
v1.11.6
95b2f66 
<a name="1.11.6"></a>
## [1.11.6](v1.11.5...v1.11.6) (2017-04-20)

### Bug Fixes

* **CONTRIBUTING:** remove section about beta releases (#2109) ([5640131](5640131))
* **sffv:** disable sffv input when few facet values FIX #2111 ([1e33c10](1e33c10)), closes [#2111](#2111)
@bobylito bobylito mentioned this issue Apr 21, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bobylito bobylito

Labels
Difficulty: Easy Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(sffv): disable sffv input when few facet values FIX #2111 algolia/instantsearch
2 participants
@bobylito @Jean-Edern