Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

priceRanges: inputs are not filled when clicking on a range #1009

Closed
xPaw opened this issue May 9, 2016 · 3 comments
Closed

priceRanges: inputs are not filled when clicking on a range #1009

xPaw opened this issue May 9, 2016 · 3 comments
Assignees
@vvo
Labels
Type: Bug

Comments

@xPaw
Copy link

xPaw commented May 9, 2016

https://community.algolia.com/instantsearch.js/documentation/#priceranges

If you click "$2 - 80", it would be nice if inputs got filled in with "2" and "80".
@vvo
Copy link
Contributor

vvo commented May 10, 2016

Hi @xPaw indeed that would be nice, do you think you could submit a PR?

@xPaw
Copy link
Author

xPaw commented May 10, 2016

do you think you could submit a PR?

Sadly not.

@vvo vvo added the Type: Bug label May 10, 2016
@bobylito
Copy link
Contributor

I think that the issue is more general. Those inputs should be connected to the state, in the same fashion that the search box is, so that any other widget filtering changing the values of the refinement should have an impact here.

@vvo vvo changed the title Fill inputs in when clicking precalculated price ranges in priceRanges priceRanges: inputs are not filled when clicking on a range Jun 13, 2016
@vvo vvo added the ready label Jul 6, 2016
@vvo vvo self-assigned this Jul 6, 2016
vvo pushed a commit that referenced this issue Jul 6, 2016
fix(pricesRange): fill the form according to the current refinement
bf4d57c 
fixes #1009
@vvo vvo added in progress and removed ready labels Jul 7, 2016
@vvo vvo closed this as completed in 12ebde7 Jul 11, 2016
vvo pushed a commit that referenced this issue Jul 11, 2016
v1.6.2
901f9fd 
<a name="1.6.2"></a>
## [1.6.2](v1.6.1...v1.6.2) (2016-07-11)

### Bug Fixes

* **paginationLink:** it's aria-label not ariaLabel (#1125) ([70a190c](70a190c))
* **pricesRange:** fill the form according to the current refinement (#1126) ([12ebde7](12ebde7)), closes [#1009](#1009)
* **rangeSlider:** handles now support stacking (#1129) ([ad394d3](ad394d3))
* **rangeSlider:** use stats min/max when only user min or max is provided (#1124) ([4348463](4348463)), closes [#1004](#1004)
* **searchBox:** force cursor position to be at the end of the query (#1123) ([8a27769](8a27769)), closes [#946](#946)
* **searchBox:** IE8, IE9 needs to listen for setQuery ([97c166a](97c166a))
* **searchBox:** update helper query on every keystroke (#1127) ([997c0c2](997c0c2)), closes [#1015](#1015)
* **urlSync:** urls should be safe by default (#1104) ([db833c6](db833c6)), closes [#982](#982)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vvo vvo

Labels
Type: Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vvo @bobylito @xPaw