Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight still visible after calling Window.makeWindowFullyTransparent() #49

Open
Adrian-Samoticha opened this issue Dec 4, 2022 · 2 comments
Labels
bug Something isn't working help wanted Extra attention is needed macOS This issue is related to macOS

Comments

@Adrian-Samoticha
Copy link
Collaborator

Calling Window.makeWindowFullyTransparent() (introduced in #48) is supposed to make the window fully transparent (with only flutter-drawn widgets, the title, and the traffic light buttons remaining visible), however, a thin, white line, which is supposed to represent a highlight on top of the window, still remains visible:

image

Since this is unintended, it is currently considered a bug. Ideally, there would be methods called Window.enableHighlight() and Window.disableHighlight() which could be called by Window.makeWindowFullyTransparent() to remove the line, however, I could not find a way to achieve this.

For this reason, I am opening this issue with a “help wanted” label. If anybody knows of a way to disable the highlight of an NSWindow within Swift, please reach out to me.

@Adrian-Samoticha Adrian-Samoticha added bug Something isn't working help wanted Extra attention is needed macOS This issue is related to macOS labels Dec 4, 2022
@damywise
Copy link
Contributor

damywise commented Dec 5, 2022

window_manager's setAsFrameless removes the highlight (though not the border at the left). You might wanna have a look at that as a start.
image

@Adrian-Samoticha
Copy link
Collaborator Author

Adrian-Samoticha commented Dec 5, 2022

Don't worry about the border, that one is caused by the visual effect subview of the sidebar. setAsFrameless removes the .titled style mask, however, doing so also has other effects, such as removing the traffic light buttons and the window's title, as well as (I believe) preventing the window from receiving keyboard events. That said, adding a function that allows the user to modify the style mask wouldn't hurt, I suppose.

Edit: I have opened an issue (#50) regarding the modification of the window's style mask.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed macOS This issue is related to macOS
Projects
None yet
Development

No branches or pull requests

2 participants