-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix plankian jitter #1976
Fix plankian jitter #1976
Conversation
Reviewer's Guide by SourceryThis pull request addresses the issue of plankian jitter in the albumentations library. The changes focus on improving the robustness and correctness of the planckian_jitter function, adding comprehensive test cases, and refining the PlanckianJitter transform class. The modifications ensure proper handling of edge cases, interpolation, and consistency across different modes and temperature ranges. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ternaus - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Fixes: #1968
Summary by Sourcery
Fix the Planckian jitter function to handle out-of-range temperatures by clamping them to valid values, enhance interpolation logic, and add comprehensive tests for edge cases and consistency.
Bug Fixes:
Enhancements:
Tests: