Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show in check message how to disable checks #1855

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Conversation

ternaus
Copy link
Collaborator

@ternaus ternaus commented Jul 24, 2024

Addresses #1851

Summary by Sourcery

Enhanced the log messages in the version check functionality to include instructions on how to disable automatic update checks. Updated existing tests to reflect these changes and added new tests for domain adaptation functionalities.

  • Enhancements:
    • Added information on how to disable automatic update checks in the log messages for both successful and failed update checks.
  • Tests:
    • Updated existing tests to verify the new log messages that include instructions on disabling automatic update checks.
    • Added new tests for domain adaptation functionalities including MinMaxScaler, StandardScaler, and PCA.

Copy link
Contributor

sourcery-ai bot commented Jul 24, 2024

Reviewer's Guide by Sourcery

This pull request enhances the update check message in 'albumentations/check_version.py' to include instructions for disabling automatic update checks and updates related test cases in 'tests/test_check_version.py'. Additionally, it introduces new test cases for domain adaptation functionalities in 'tests/test_domain_adaptation.py'.

File-Level Changes

Files Changes
albumentations/check_version.py
tests/test_check_version.py
Enhanced the update check message to include instructions for disabling automatic update checks and updated related test cases.
tests/test_domain_adaptation.py Introduced new test cases for domain adaptation functionalities such as MinMaxScaler, StandardScaler, and PCA.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ternaus - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider breaking the longer log messages into multiple lines for better readability. While the additional information is valuable, very long single-line messages can be harder to read in log files.
Here's what I looked at during the review
  • 🟡 General issues: 3 issues found
  • 🟢 Security: all looks good
  • 🟡 Testing: 6 issues found
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

albumentations/check_version.py Show resolved Hide resolved
albumentations/check_version.py Show resolved Hide resolved
albumentations/check_version.py Show resolved Hide resolved
tests/test_check_version.py Show resolved Hide resolved
tests/test_check_version.py Show resolved Hide resolved
tests/test_domain_adaptation.py Show resolved Hide resolved
tests/test_domain_adaptation.py Show resolved Hide resolved
tests/test_domain_adaptation.py Show resolved Hide resolved
tests/test_domain_adaptation.py Show resolved Hide resolved
@ternaus ternaus merged commit bc54975 into main Jul 24, 2024
17 checks passed
@ternaus ternaus deleted the fix_check_version_message branch July 24, 2024 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant