Added an explicit include for rsa.h, needed for openssl 1.1.1+ support #794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@johnhe4 would you mind filing an issue for the CMake problem you had in the master branch? |
alanxz
reviewed
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cross-compiling on my Intel mac for an arm64 mac failed at the build phase due to a missing include for
rsa.h. I tested onv0.13.0but was unable to test on master due to a cmake error (I can make a separate ticket for that if needed).I depend on OpenSSL 1.1.1w (for better cross-compilation support) and am guessing older releases of OpenSSL have a different include graph that must indirectly include
rsa.h.