Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

amqp_open_socket_inner does not correctly try all addresses #430

Closed
alanxz opened this issue Jul 25, 2017 · 0 comments · Fixed by #431
Closed

amqp_open_socket_inner does not correctly try all addresses #430

alanxz opened this issue Jul 25, 2017 · 0 comments · Fixed by #431
Labels
t:bug

Comments

@alanxz
Copy link
Owner

alanxz commented Jul 25, 2017

amqp_open_socket_inner if connect is attempted on a socket, a subsequent address returned by getaddrinfo is not attempted, even if its before the deadline has expired.

See also
@alanxz alanxz added the t:bug label Jul 25, 2017
@alanxz alanxz mentioned this issue Jul 25, 2017
Open
alanxz added a commit that referenced this issue Jul 25, 2017
@alanxz
Lib: simplify socket connection logic
5e81b22 
Refactor amqp_socket_open_inner so that the socket connection logic is
in it's own OS-specific socket_connect function, and the host resolution
and retry logic calls this. This makes the socket connection logic
easier to understand and reduces the number of win32 #ifdefs.

This also fixes an issue where multiple hostnames are not tried if
connect doesn't fail immediately.

Fixes #430
@alanxz alanxz mentioned this issue Jul 25, 2017
Merged
alanxz added a commit that referenced this issue Jul 25, 2017
@alanxz
Lib: simplify socket connection logic
4252b1b 
Refactor amqp_socket_open_inner so that the socket connection logic is
in it's own OS-specific socket_connect function, and the host resolution
and retry logic calls this. This makes the socket connection logic
easier to understand and reduces the number of win32 #ifdefs.

This also fixes an issue where multiple hostnames are not tried if
connect doesn't fail immediately.

Fixes #430
alanxz added a commit that referenced this issue Jul 25, 2017
@alanxz
Lib: simplify socket connection logic
ca5b365 
Refactor amqp_socket_open_inner so that the socket connection logic is
in it's own OS-specific socket_connect function, and the host resolution
and retry logic calls this. This makes the socket connection logic
easier to understand and reduces the number of win32 #ifdefs.

This also fixes an issue where multiple hostnames are not tried if
connect doesn't fail immediately.

Fixes #430
alanxz added a commit that referenced this issue Jul 25, 2017
@alanxz
Lib: simplify socket connection logic
59c0fc3 
Refactor amqp_socket_open_inner so that the socket connection logic is
in it's own OS-specific socket_connect function, and the host resolution
and retry logic calls this. This makes the socket connection logic
easier to understand and reduces the number of win32 #ifdefs.

This also fixes an issue where multiple hostnames are not tried if
connect doesn't fail immediately.

Fixes #430
alanxz added a commit that referenced this issue Jul 25, 2017
@alanxz
Lib: simplify socket connection logic
b252de9 
Refactor amqp_socket_open_inner so that the socket connection logic is
in it's own OS-specific socket_connect function, and the host resolution
and retry logic calls this. This makes the socket connection logic
easier to understand and reduces the number of win32 #ifdefs.

This also fixes an issue where multiple hostnames are not tried if
connect doesn't fail immediately.

Fixes #430
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
t:bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Lib: simplify socket connection logic alanxz/rabbitmq-c
1 participant
@alanxz