Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: export web-socket #99

Merged
merged 1 commit into from
Dec 28, 2023

Conversation

paralin
Copy link

@paralin paralin commented Dec 19, 2023

Export the WebSocket type and constructor.

Fixes: #78

Export the WebSocket type and constructor.

Fixes: alanshaw#78

Signed-off-by: Christian Stewart <christian@aperture.us>
@paralin
Copy link
Author

paralin commented Dec 19, 2023

import duplex from 'it-ws/duplex'
import type WebSocket from 'it-ws/web-socket'

@paralin paralin mentioned this pull request Dec 19, 2023
@paralin
Copy link
Author

paralin commented Dec 27, 2023

@alanshaw any word on this? thanks.

@alanshaw
Copy link
Owner

Why not export the type from the main export - do you need the constructor?

@paralin
Copy link
Author

paralin commented Dec 28, 2023

Yes

@alanshaw alanshaw merged commit 9687a51 into alanshaw:master Dec 28, 2023
@paralin
Copy link
Author

paralin commented Dec 28, 2023

Thanks!

@paralin paralin deleted the fix-export-web-socket branch December 28, 2023 21:11
github-actions bot pushed a commit that referenced this pull request Jul 22, 2024
## [6.1.2](v6.1.1...v6.1.2) (2024-07-22)

### Bug Fixes

* export web-socket ([#99](#99)) ([9687a51](9687a51))
* it-goodbye expects the source to be an async generator ([#115](#115)) ([d00509c](d00509c))
Copy link

🎉 This PR is included in version 6.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export WebSocket
2 participants