feat: support react-native #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
React-native has a hobbled URL class that seems to make it's own WebSocket class cause a fatal crash so stringify it before passing it in. Otherwise the URL class is supported everywhere now so no need to use iso-url any more. Also noteworthy is that react-native doesn't have any node core modules so we have to use a similar browser override system to ensure the pure-js/browser APIs are used instead.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #97 +/- ##
==========================================
- Coverage 96.07% 94.71% -1.36%
==========================================
Files 22 22
Lines 967 1021 +54
Branches 160 183 +23
==========================================
+ Hits 929 967 +38
- Misses 38 54 +16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Refs: libp2p/js-libp2p#2229 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
React-native has a hobbled URL class that seems to make it's own WebSocket class cause a fatal crash so stringify it before passing it in.
Otherwise the URL class is supported everywhere now so no need to use iso-url any more.
Also noteworthy is that react-native doesn't have any node core modules so we have to use a similar browser override system to ensure the pure-js/browser APIs are used instead.