fix: handle null server address #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The types for the `Server.address()` method in `@types/ws` are missing a return type of `null`. This can happen when a incoming connection is recieved after the ws `Server` has been closed but before the underlying HTTP server has finished closing down. DefinitelyTyped/DefinitelyTyped#70132 will address the type problem, the change here is to handle the `null` return value. It also calls `.destroy` on the incoming message since we'd want to reclaim the resources immediately and not wait for the remote to time out.
|
🎉 This issue has been resolved in version 6.1.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The types for the
Server.address()method in@types/wsare missing a return type ofnull. This can happen when a incoming connection is recieved after the wsServerhas been closed but before the underlying HTTP server has finished closing down.DefinitelyTyped/DefinitelyTyped#70132 will address the type problem, the change here is to handle the
nullreturn value.It also calls
.destroyon the incoming message since we'd want to reclaim the resources immediately and not wait for the remote to time out.Fixes #114