Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: options are optional #16

Merged
merged 1 commit into from
Apr 9, 2021

Conversation

vasco-santos
Copy link

@vasco-santos vasco-santos commented Apr 9, 2021

Options for decode and encode are optional. This creates typescript errors in libp2p unless we provide options

cc @alanshaw

@codecov
Copy link

codecov bot commented Apr 9, 2021

Codecov Report

Merging #16 (7ce1113) into master (2005238) will not change coverage.
The diff coverage is n/a.

❗ Current head 7ce1113 differs from pull request most recent head 2643b01. Consider uploading reports for the commit 2643b01 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master      #16   +/-   ##
=======================================
  Coverage   97.69%   97.69%           
=======================================
  Files           7        7           
  Lines         130      130           
=======================================
  Hits          127      127           
  Misses          3        3           
Impacted Files Coverage Δ
src/decode.js 95.65% <ø> (ø)
src/encode.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2005238...2643b01. Read the comment docs.

@alanshaw alanshaw merged commit 2a914ef into alanshaw:master Apr 9, 2021
@vasco-santos
Copy link
Author

@alanshaw can you please release this when you have a moment? 🙏🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants