Add #_setAttributes and clean up #setElement.

[braddunbar]

Setting attributes and setting the element are distinct operations. It's telling that we had to pass the argument through two methods before using it. Further, it will complicate future additions to the #setElement API.

I realize it's another method that needs to the overwritten but it's a distinct operation and I think we'll regret conflating the two.

[akre54]

Further, it will complicate future additions to the #setElement API.

What extras could setElement have? Keeping 3003 simple and tiny is a huge win here.

[braddunbar]

Keeping 3003 simple and tiny is a huge win here.

This is great to hear as I agree completely! 😃 That said, I think that passing attributes through an unrelated function just so that we can then pass it to another unrelated function is the more complex option.

What extras could setElement have?

This seems like an odd thing to say when submitting a pull request that itself adds extras to setElement. I imagine we thought the same thing when we added delegate as a boolean argument. We just dodged that bullet, let's do it the first time this go 'round.

[akre54]

Fair nuff