Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Am I missing something? $el still exists. #12

Closed
SomethingSexy opened this issue Feb 13, 2015 · 7 comments
Closed

Am I missing something? $el still exists. #12

SomethingSexy opened this issue Feb 13, 2015 · 7 comments
Labels

Comments

@SomethingSexy
Copy link

Since Backbone.NativeView is not overriding _ensureElement, if I am using Backbone.NativeView directly, $el still exists. Which isn't a problem per say, but your documentation says otherwise.

@akre54
Copy link
Owner

akre54 commented Feb 13, 2015

Are you using the master branch of Backbone? There hasn't yet been a tagged release of Backbone with the necessary changes (jashkenas/backbone#3003) so in the interim you should point your package manager to the current git hash.

Since Backbone.NativeView is not overriding _ensureElement

We override _setElement (a new method from pull 3003) which gets called from setElement (and _ensureElement in turn). No $el property is created.

@SomethingSexy
Copy link
Author

Ah that makes sense, I didn't see that being mentioned. I am running off 1.1.2.

@ropbla9
Copy link

ropbla9 commented Feb 14, 2015

Tyle, make native version of Can JS or Sammy.js. I hate jQuery and my
favorite frameworks run on top of it, haha.

2015-02-13 23:39 GMT-03:00 Tyler Cvetan notifications@github.com:

Ah that makes sense, I didn't see that being mentioned. I am running off
1.1.2.


Reply to this email directly or view it on GitHub
#12 (comment)
.

@SomethingSexy
Copy link
Author

@akre54 have they given you any idea of when 1.2.0 is coming out?

@akre54
Copy link
Owner

akre54 commented Feb 14, 2015

Hopefully soon. There's a thread in the backbone issues that you promoted
me to restart that you can check out and chime in on if you like. We just
need to document all the changes and figure out what else will make it in
for 1.2.0

On Sat, Feb 14, 2015, 15:57 Tyler Cvetan notifications@github.com wrote:

@akre54 https://github.com/akre54 have they given you any idea of when
1.2.0 is coming out?


Reply to this email directly or view it on GitHub
#12 (comment)
.

@akre54
Copy link
Owner

akre54 commented May 18, 2015

Backbone 1.2.0 is out! Test away!

@SomethingSexy
Copy link
Author

Boom! Thanks. I will pick this back up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants