Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

should recreate KafkaProducer once actor restart #30

Closed
He-Pin opened this issue Aug 21, 2015 · 4 comments
Closed

should recreate KafkaProducer once actor restart #30

He-Pin opened this issue Aug 21, 2015 · 4 comments
Milestone
0.8.0

Comments

@He-Pin
Copy link
Member

He-Pin commented Aug 21, 2015

the current code have a bug that once there is an exception occur,theKafkaActorSubscriber is restarted ,and then cause the producer was passed in and was closed then it will cause exception of producer already closed,and will trap the subscriber.
@He-Pin
Copy link
Member Author

He-Pin commented Aug 21, 2015

my bad seems:)

@He-Pin He-Pin closed this as completed Aug 21, 2015
@He-Pin
Copy link
Member Author

He-Pin commented Aug 21, 2015

but the problem is still there,I will come up with a proper fix.

@kciesielski
Copy link
Contributor

See my comment on #29

@kciesielski kciesielski added this to the 0.8.0 milestone Aug 26, 2015
@kciesielski
Copy link
Contributor

@hepin1989 I just added some more changes. Now even with default error handling the underlying resources will not be closed on restart. Coming in 0.8.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.8.0
Development

No branches or pull requests
2 participants
@He-Pin @kciesielski