Feature: Adding support for specific network versions import and update-local #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rschneider-chwy
changed the title
|
Any update on if this will be merged? This would be useful for something I'm working on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello from your friends at Chewy! 🐶🐱
Fixes #33 and fixes #73
Taking a crack at adding support for specific versions for
update-localandimport. PAPI V1 supports specifying the network with calling GET latest version, so I added a check to pass the--networkwhen present:If the
--propveris selected it will grab the specific version instead:I tested it locally and it looks to be working! Let me know if there's anything more I need to provide.