Skip to content

Commit

Permalink
fix: Tests failed and not picked up in previous commit
Browse files Browse the repository at this point in the history
  • Loading branch information
ajfisher committed Dec 28, 2019
1 parent 94a7fc2 commit 3d23113
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion test/firmware.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ const firmware_creator = () => describe('2. Ensure creators set up correctly', (
test('2.2 Creator list has required fields', () => {
creators.forEach((creator) => {
expect(creator.id).toBeDefined();
expect(parseInt(creator.id, 16) > 0).toBe(true); // is a number
expect(parseInt(creator.id, 16) >= 0).toBe(true); // is a number
expect(creator.gh).toBeDefined();
expect(creator.name).toBeDefined();
expect(creator.name.length > 0).toBe(true);
Expand Down
4 changes: 2 additions & 2 deletions test/interchange_client.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@ const client_shape = () => describe('1. Client Shape is correct', () => {
expect(typeof(ic_client.close)).toBe('function');
});

test('1.2 Client should call the ready event when opened with a valid port', (done) => {
ic_client.on('ready', () => {
test('1.2 Client should call the connected event when opened with a valid port', (done) => {
ic_client.on('connected', () => {
expect(ic_client.serialport.path).toBe('/dev/dummy');
expect(ic_client.serialport.binding.isOpen).toBe(true);
done();
Expand Down

0 comments on commit 3d23113

Please sign in to comment.