Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some issues #12

Closed
billhhh opened this issue Nov 4, 2019 · 2 comments
Closed

Some issues #12

billhhh opened this issue Nov 4, 2019 · 2 comments

Comments

@billhhh
Copy link

billhhh commented Nov 4, 2019 •
edited
Loading

Thank you for sharing your great work!

I am reading your codes now, but I found some weird parts. They are probably bugs while I am not sure as well. Please point me out if I am wrong

  1. https://github.com/airsplay/R2R-EnvDrop/blob/master/r2r_src/agent.py#L184, cannot find matched "if" to this "else".

  2. https://github.com/airsplay/R2R-EnvDrop/blob/master/r2r_src/agent.py#L570, five return values which do not match the function definitions here.
@airsplay
Copy link
Owner

airsplay commented Nov 4, 2019

Thanks for your interest :).

  1. It's a statement in Python called for-else; Please see here for the usage.

  2. It is related to the beam search results. However, the beam search has some unknown problem because I clean the code a little bit. Thus I did not go into these functions but publish the code as a preview. The correct beam-search results and code are available here. I aim to locate/fix it soon and release a new version with beam-search.

Best,
Hao

@billhhh
Copy link
Author

billhhh commented Nov 4, 2019

Thank you for your reply!

@billhhh billhhh closed this as completed Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@airsplay @billhhh