Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc, android] Adding section to fix gradle problems #910

Merged
merged 2 commits into from
Dec 27, 2016

Conversation

alialamine
Copy link
Contributor

@alialamine alialamine commented Dec 20, 2016

This adds a solution to fix the mismatch between the play-services in case the user wants to use a different version

This fixes #877, #831 and #874 for all versions while keeping compatibility with projects using older version of play-services

This adds a method to fix the mismatch between the play-services in case the user wants to use a different version
@alialamine alialamine changed the title (doc, android) Adding section to fix gradle problems [doc, android] Adding section to fix gradle problems Dec 20, 2016
@Froelund
Copy link

I can't get this to work as is.
When I run with the change explained, I get this error.

* What went wrong:
A problem occurred evaluating project ':app'.
> Could not find method exclude() for arguments [{group=com.google.android.gms, module=play-services-base}] on project ':react-native-maps'.

I've change it to

    compile(project(':react-native-maps')){
        exclude group: 'com.google.android.gms', module: 'play-services-base'
        exclude group: 'com.google.android.gms', module: 'play-services-maps'
    }
    compile 'com.google.android.gms:play-services-base:10.0.1'
    compile 'com.google.android.gms:play-services-maps:10.0.1'

and it works

@alialamine
Copy link
Contributor Author

That's what i meant, to replace the <> with the version number that you need. Have any idea for how to make it less confusing??

@alialamine
Copy link
Contributor Author

Nevermind the above, I'll fix the syntax ( and weird cz the version that I have worked for me)

Fixed some syntax as suggested by @Froelund as the previous one doesn't work on some versions of gradle.
@christopherdro christopherdro merged commit 4a055c0 into react-native-maps:master Dec 27, 2016
@alialamine alialamine deleted the docs-fix branch December 28, 2016 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants