Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow legalLabelInsets to be changed and animated #873

Merged
merged 4 commits into from
Dec 8, 2016

Conversation

scarlac
Copy link
Contributor

@scarlac scarlac commented Dec 8, 2016

Added docs for legalLabelInsets as well. Related to #840

While property is structurally identical to EdgePadding, used for region fitting, they serve completely
different purposes. So a new type is defined.

Default left empty since it's an OS default (around {left: 10, bottom: 10} in my tests)

Updated example to include a button to animate the legal label.
While structurally identical to EdgePadding, they serve completely
different purposes. Default left empty since it's an OS default (around
{left: 10, bottom: 10})
Copy link
Contributor

@gilbox gilbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome @scarlac ! can you please fix the lint errors?

/home/travis/build/airbnb/react-native-maps/example/examples/LegalLabel.js
error A space is required after '{' object-curly-spacing
error A space is required before '}' object-curly-spacing

@gilbox gilbox merged commit 7869dfd into react-native-maps:master Dec 8, 2016
@gilbox
Copy link
Contributor

gilbox commented Dec 8, 2016

🏆

Exilz pushed a commit to archriss/react-native-maps that referenced this pull request Dec 9, 2016
)

* Allow legalLabelInsets to be changed and animated

Updated example to include a button to animate the legal label.

* Docs for legalLabelInsets prop

While structurally identical to EdgePadding, they serve completely
different purposes. Default left empty since it's an OS default (around
{left: 10, bottom: 10})

* Spacing / linting
@spikebrehm
Copy link

Published as v0.12.2

@scarlac
Copy link
Contributor Author

scarlac commented Dec 10, 2016

@spikebrehm and @gilbox : Thanks for the quick turn-around on these fixes. Really appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants