[iOS] Added Google Maps Circle, Polygon, Polyline, MapType Support #722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
gilbox
reviewed
Oct 24, 2016
| @@ -502,9 +498,6 @@ class MapView extends React.Component { | |||
| onMapReady: this._onMapReady, | |||
| onLayout: this._onLayout, | |||
| }; | |||
| if (Platform.OS === 'ios' && ANDROID_ONLY_MAP_TYPES.includes(props.mapType)) { | |||
| props.mapType = MAP_TYPES.STANDARD; | |||
| } | |||
There was a problem hiding this comment.
did you consider keeping this check in case someone is still using mapkit?
There was a problem hiding this comment.
@gilbox good point! I can add this check back and base it off the platform and provider
nitaliano
force-pushed
the
google-maps-ios-shapes
branch
from
9575256
to
0ce4b3e
Compare
|
Added the check back |
|
this lgtm.. @spikebrehm wanna take a peek? |
nitaliano
changed the title
|
@gilbox @spikebrehm Just added circle support |
|
👍 |
|
👍 |
|
This is perfect! Guys please merge this pull-request!! |
|
LGTM! Thanks 🍻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed the ability to draw on maps and switch the base map using the Google Maps SDK so I took a stab at adding this support.