Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

included MapUrlTile usage in README.md #687

Merged
merged 5 commits into from
Oct 13, 2016
Merged

included MapUrlTile usage in README.md #687

merged 5 commits into from
Oct 13, 2016

Conversation

ochanje210
Copy link
Contributor

No description provided.

@hohyon-ryu
Copy link

Lgtm!

loadingIndicatorColor={"#666666"}
loadingBackgroundColor={"#eeeeee"}
loadingIndicatorColor={'#666666'}
loadingBackgroundColor={'#eeeeee'}
>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think double quotes is desired for JSX. Can probably get rid of the curly braces.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate your advise. I changed back to double quotes and removed curly braces

loadingIndicatorColor={"#666666"}
loadingBackgroundColor={"#eeeeee"}
loadingIndicatorColor={'#666666'}
loadingBackgroundColor={'#eeeeee'}
>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment above.

Copy link
Contributor Author

@ochanje210 ochanje210 Oct 13, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as comment above

@spikebrehm
Copy link

Thank you!

@spikebrehm spikebrehm merged commit 15c5875 into react-native-maps:master Oct 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants