Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[android] fix gradle build setup for explorer, bump to gradle 2.2.0 #666

Merged
merged 2 commits into from
Oct 10, 2016

Conversation

gilbox
Copy link
Contributor

@gilbox gilbox commented Oct 7, 2016

maven {
// For developing the example app, expect this library to be installed as a node module
// inside of the example app. So traverse from `./android/example/node_modules/react-native-maps/android`
// to `./android/example/node_modules/react-native/android`.
// react-native should be installed since it's a peer dependency
url "$projectDir/../../react-native/android"
url "$projectDir/../example/node_modules/react-native/android"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't match the paths in the comment anymore. Are the paths in the comment correct?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@spikebrehm the comment didn't make any sense. I updated it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@spikebrehm I had mixed up commits in different branches. it's fixed now.

Copy link

@spikebrehm spikebrehm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

// For developing the example app, expect this library to be installed as a node module
// inside of the example app. So traverse from `./android/example/node_modules/react-native-maps/android`
// to `./android/example/node_modules/react-native/android`.
// react-native should be installed since it's a peer dependency

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this a useful comment?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's completely wrong, though. We don't pull from node_modules for the example app

@spikebrehm spikebrehm merged commit 3c5d4f7 into master Oct 10, 2016
@spikebrehm spikebrehm deleted the gil/fix-android-build-config branch October 10, 2016 18:38
@spikebrehm
Copy link

Do we need to release a patch fix to 0.9 for this as well?

@gilbox
Copy link
Contributor Author

gilbox commented Oct 10, 2016

@spikebrehm afaik it really only effects the explorer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants