Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pod stuff. Fix AirMaps.xcodeproj related to missing pod stuff #620

Merged
merged 1 commit into from
Sep 28, 2016

Conversation

gilbox
Copy link
Contributor

@gilbox gilbox commented Sep 27, 2016

Fix #620

My GoogleMaps PR added some unnecessary Podfile stuff to the ios/ dir. This removes it to avoid errors related to that stuff.

@lelandrichardson @spikebrehm @felipecsl

@@ -22,14 +22,8 @@
1125B2E61C4AD3DA007D0023 /* AIRMapPolylineManager.m in Sources */ = {isa = PBXBuildFile; fileRef = 1125B2D61C4AD3DA007D0023 /* AIRMapPolylineManager.m */; };
1125B2E71C4AD3DA007D0023 /* RCTConvert+MoreMapKit.m in Sources */ = {isa = PBXBuildFile; fileRef = 1125B2D91C4AD3DA007D0023 /* RCTConvert+MoreMapKit.m */; };
1125B2F21C4AD445007D0023 /* SMCalloutView.m in Sources */ = {isa = PBXBuildFile; fileRef = 1125B2F11C4AD445007D0023 /* SMCalloutView.m */; };
DA6C26381C9E2AFE0035349F /* AIRMapUrlTile.m in Sources */ = {isa = PBXBuildFile; fileRef = DA6C26371C9E2AFE0035349F /* AIRMapUrlTile.m */; settings = {ASSET_TAGS = (); }; };
DA6C263E1C9E324A0035349F /* AIRMapUrlTileManager.m in Sources */ = {isa = PBXBuildFile; fileRef = DA6C263D1C9E324A0035349F /* AIRMapUrlTileManager.m */; settings = {ASSET_TAGS = (); }; };

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These AIRMapUrlTile lines should stay.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh i just realized they were moved below

@gilbox
Copy link
Contributor Author

gilbox commented Sep 27, 2016

@spikebrehm i think this is ready

@spikebrehm
Copy link

@gilbox where did you land in terms of creating a separate xcodeproj with the Google maps classes?

@gilbox
Copy link
Contributor Author

gilbox commented Sep 27, 2016

@spikebrehm more complicated than we thought

@spikebrehm spikebrehm merged commit e4cdf62 into master Sep 28, 2016
@spikebrehm spikebrehm deleted the gil/pod-fix branch September 28, 2016 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants