Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix list of examples on Android #597

Merged
merged 1 commit into from
Sep 22, 2016
Merged

Conversation

spikebrehm
Copy link

In #548, we added Google Maps support for iOS. We changed the example
app to list examples based on whether they support Google Maps on iOS.
The logic was such that on Android it only showed the examples that are
iOS + Google Map compatible, however on Android this condition is
irrelevant, this commit changes it to show all examples on Android,
regardless.

Before

screen shot 2016-09-22 at 10 37 24 am

After

screen shot 2016-09-22 at 10 37 04 am

to: @gilbox

In #548, we added Google Maps support for iOS. We changed the example
app to list examples based on whether they support Google Maps on iOS.
The logic was such that on Android it only showed the examples that are
iOS + Google Map compatible, however on Android this condition is
irrelevant, this commit changes it to show all examples on Android,
regardless.
@gilbox
Copy link
Contributor

gilbox commented Sep 22, 2016

thanks for fixing! 👍

@spikebrehm spikebrehm merged commit 8ab3668 into master Sep 22, 2016
@spikebrehm spikebrehm deleted the fix-example-list-android branch September 22, 2016 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants