Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't fit to elements if no positions added #567

Merged
merged 1 commit into from
Sep 12, 2016

Conversation

ryankask
Copy link
Contributor

@ryankask ryankask commented Sep 11, 2016

This commit prevents the crash mentioned in #180. It is identical to the implementation in AirMapView#fitToSuppliedMarkers().

This doesn't actually fix the issue mentioned in #180 because while the app no longer crashes, the elements aren't zoomed unless you use a setTimeout hack or something similar. @igrayson has written about this there.

It would be great to figure out why that isn't working, however.

@spikebrehm
Copy link

LGTM, thanks.

@spikebrehm spikebrehm merged commit d854912 into react-native-maps:master Sep 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants