Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Minor code cleanup #564

Merged
merged 1 commit into from
Sep 12, 2016

Conversation

felipecsl
Copy link
Contributor

  • Remove unused variables and fields
  • Fix compiler warnings (unchecked, deprecation, etc)

* Remove unused variables and fields
* Fix compiler warnings (unchecked, deprecation, etc)
@felipecsl
Copy link
Contributor Author

@spikebrehm this should be a simple one I guess?

@@ -404,20 +383,14 @@ public void addFeature(View child, int index) {
AirMapPolyline polylineView = (AirMapPolyline) child;
polylineView.addToMap(map);
features.add(index, polylineView);
Polyline polyline = (Polyline) polylineView.getFeature();
polylineMap.put(polyline, polylineView);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These maps aren't used, eh? You've smoke tested the example app?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, these maps are never queried

@spikebrehm spikebrehm merged commit a7fc88b into react-native-maps:master Sep 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants