Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumped google-play-things in build.gradle to 9.+ #533

Merged
merged 2 commits into from
Sep 2, 2016

Conversation

i8wu
Copy link

@i8wu i8wu commented Sep 2, 2016

Bumping build.gradle to use latest version of google-play, should fix crashing when conflicting with other node modules that use the 9.+ version

@spikebrehm
Copy link

Would this cause issues for apps that still need 8.4.0?

AFAIK, that version number is a minimum, meaning that 8.4.0 means "8.4.0 and above".

cc: @felipecsl

@i8wu
Copy link
Author

i8wu commented Sep 2, 2016

From my usage when different node_modules have different play versions it causes issues. In other words 8.4.0 doesn't seem to be a minimum, and causes app crash. See #452 #420 . This will cause issues with modules that are using 8.4.0, but I guess from the Compatibility line in the readme, I would assume we would want to strictly use the latest versions of google-play things unless there was a conflict with react-native-maps itself?

@jeveloper
Copy link

You can keep it at 8.4.0 as i dont think there are any specific features from 9.x that are used
Also it'll allow for this component to work on older devices (in fact a lot of factory built devices come with outdated google play ).

This will cause a white map btw , i can confirm.
E.g. if the device has google play services 7.x , it'll be a white map(missing) due to minimum 8.4

@i8wu
Copy link
Author

i8wu commented Sep 2, 2016

Is it common for users not to upgrade their play services? I can't seem to find any statistics about this. Also, while keeping it at 8.4.0 will support older devices, it will cause crashes for modules that use newer versions of google play services. This means that modules that do use features from 9.x will be incompatible with react-native-maps.

@felipecsl
Copy link
Contributor

I'd definitely recommend bumping to v9

@alexHlebnikov
Copy link

Why not update to latest version - 9.4.0?

@spikebrehm
Copy link

Why not update to latest version - 9.4.0?

Sounds good. @felipecsl, our resident Android expert, is recommending that. (Thanks for bearing with my ignorance about Android 😸 .)

@i8wu can you update the PR?

@i8wu
Copy link
Author

i8wu commented Sep 2, 2016

Updated

@felipecsl
Copy link
Contributor

👍

@spikebrehm
Copy link

Thanks!

@spikebrehm spikebrehm merged commit f0ecffd into react-native-maps:master Sep 2, 2016
@spikebrehm
Copy link

Just published 0.8.1 that includes this change.

@spikebrehm
Copy link

It turns out 0.8.1 was faulty, because my working directory had an additional example app containing the react-native node module, which got published as part of the NPM package (:facepalm:), causing a @providesModule error, so I've unpublished it and published 0.8.2. Use that instead!

@rops
Copy link
Contributor

rops commented Sep 19, 2016

Guys we lost support for older devices by upgrading to 9+ though.

@felipecsl
Copy link
Contributor

@rops why is that? Are there any devices that are not compatible with GPS v9?

@rops
Copy link
Contributor

rops commented Sep 19, 2016

You would get this nice alert on a device running Android 19 :(

XXX won't run unless you update Google Play services.

@felipecsl
Copy link
Contributor

yeah that sucks but you should always be able to update your GPS and eventually if you don't, most apps will stop working 😢

@rops
Copy link
Contributor

rops commented Sep 19, 2016

Can you update GPS without doing a full OS upgrade?

@felipecsl
Copy link
Contributor

felipecsl commented Sep 19, 2016

I think so. AFAIK GPS upgrades are not tied to OS version. I scanned through the release notes and didn't find anythink mentioning that in the v9 release changes
If you have an android 19 or older and could confirm here, that would be great

@alexHlebnikov
Copy link

You can download latest version of GPS anytime from Play Market and it's a common thing.

@i8wu
Copy link
Author

i8wu commented Sep 20, 2016

It seems my users with older versions of Google Play Services did not get the MapView display, but got a gray view with an "Update" button. When pressing the update button, my app crashes. If the user updates Play Services from the Play Store the MapView renders fine. Is there something in the MapView that needs to be caught?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants