Add ESLint and fix a number of linting violations #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1 @@ | |||
| node_modules | |||
There was a problem hiding this comment.
this should already be gitignored, and as such, eslint should already ignore it - why is this needed?
There was a problem hiding this comment.
In my testing, without ignoring this, eslint . takes significantly longer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ESLint using the
eslint-config-airbnbpreset, and override a few of the rules to better fit with React Native (prefer-object-spread,react/jsx-filename-extension) or to suppress a number of the warnings until we can get everything cleaned up (no-use-before-define,no-underscore-dangle).Add
npm run lintcommand, which runs ESLint. Currently, there are still 488 linting errors, which I'd like to fix in follow-up PRs to prevent a bunch of merge conflicts from popping up.Note: This doesn't actually enforce linting to pass in CI before merging. That will happen once we address all the issues.
Please take a look @lelandrichardson @jrichardlai.
cc: @ljharb