Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shouldUsePinView #344

Merged

Conversation

paulshen
Copy link
Contributor

Update shouldUsePinView to handle when subviews are not yet updated to reflect reactSubviews.

Feel free to abandon this but quick attempt at a fix of an issue where markers were using the default pins instead of the custom react subviews. Stepping through the code it looks like this runs before UIView.didUpdateReactSubviews when subviews are actually updated.

Update shouldUsePinView to handle when `subviews` are not yet updated to reflect `reactSubviews`
@lelandrichardson lelandrichardson merged commit 6470fe3 into react-native-maps:master Jul 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants