Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add native animation for Markers on Android (with documentation) #1976

Merged
merged 5 commits into from
Jan 22, 2018
Merged

Add native animation for Markers on Android (with documentation) #1976

merged 5 commits into from
Jan 22, 2018

Conversation

BEGEMOT9I
Copy link
Contributor

This is a copy of #1782 with documentation.

@rborn
Copy link
Collaborator

rborn commented Jan 19, 2018

LGTM
@alvelig 🐽

@alvelig
Copy link
Contributor

alvelig commented Jan 19, 2018

@rborn
Copy link
Collaborator

rborn commented Jan 22, 2018

@BEGEMOT9I could you please fix the things travis is complaining ? 🤗

@rborn
Copy link
Collaborator

rborn commented Jan 22, 2018

LGTM @alvelig 🐽

@alvelig
Copy link
Contributor

alvelig commented Jan 22, 2018

Great! LGTM

@rborn rborn merged commit 8363c7c into react-native-maps:master Jan 22, 2018
@henninghall
Copy link

Great improvement! What about iOS, is it already using native drivers for marker animations?

@dagostal
Copy link

Hi - I am a noob, when i implement this i get an error "expected dynamic type 'double' but had type 'null' (constructing aruments for UIManger.dispatchViewManagerCommand at argument index 1.

I am putting the correct arguments into the function- Any idea?
Thanks so much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants