Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Ground Overlay Support (PR-1586) #1918

Merged
merged 1 commit into from
Dec 29, 2017
Merged

Merge Ground Overlay Support (PR-1586) #1918

merged 1 commit into from
Dec 29, 2017

Conversation

alvelig
Copy link
Contributor

@alvelig alvelig commented Dec 22, 2017

Replaces #1586, as after rebase to the current master.

@alvelig
Copy link
Contributor Author

alvelig commented Dec 22, 2017

@isener mind checking my rebased PR? (BTW thank you very much)

@isener
Copy link
Contributor

isener commented Dec 23, 2017

Good work mate, I don't have time to check fully. Will do it asap on the fly

Copy link
Collaborator

@rborn rborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @alvelig did you test to see if it runs ok ?

@alvelig
Copy link
Contributor Author

alvelig commented Dec 23, 2017

@rborn frankly speaking, no. I just checked that it was building ok. Did not check the features.

@rborn
Copy link
Collaborator

rborn commented Dec 29, 2017

I'll merge and wait for the community feedback.

@rborn rborn merged commit 4c61324 into master Dec 29, 2017
@tmaly1980
Copy link
Contributor

tmaly1980 commented Dec 29, 2017

React.PropTypes is deprecated. Every where else in this package we're using the separate package. @alvelig what version of RN were you building with? I'm pretty sure you would have noticed it failing if it were a recent version. Generally I'd recommend testing with newer versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants