Fixes issue running on ReactNative 0.42.3 - 'MapMarker' has no propType for native prop 'AIRMapMarker.testId' of native type 'String' #1792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! Thanks for making this pull request. The changes here will end up causing issues for apps using the latest versions of RN since View.propTypes is deprecated. Could you update your pull request to use this approach? https://github.com/airbnb/react-native-maps/blob/master/lib/components/MapView.js#L49-L50 Would be great to check that all components here https://github.com/airbnb/react-native-maps/tree/master/lib/components are similiar. |
|
Great idea @christopherdro, thanks for pointing me in the right direction. This bug took me an ungodly amount of time to find and fix, and i like your overall solution. We should be good to go with this PR now! |
|
Thank you sir! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you've been running into the dreaded
MapMarker has no propType for native prop AIRMapMarker.testID of native type Stringor something similar, this is the fix! Two lines!Closes #1650
Closes #1532
Closes #1656