Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for new Android camera movement APIs #1710

Conversation

IjzerenHein
Copy link
Contributor

OnCameraChangeListener is deprecated and should no longer be used. This PR adds support for the new more powerful APIs and removes the old (quite hacky..) region detection code. This fixes various issues and paves the way for distinguishing between gestures and manual/programatic animations at the same time.

image
https://developers.google.com/android/reference/com/google/android/gms/maps/GoogleMap.OnCameraChangeListener

This PR fixes #1709 and I'm pretty sure it also fixes:

`OnCameraChangeListener` is deprecated and should no longer be used. This PR adds support for new more powerful APIs and removes the old hacky region detection code. This fixes various issues and paves the way for distinguishing between gestures and manual/programatic animations the same time.

https://developers.google.com/android/reference/com/google/android/gms/maps/GoogleMap.OnCameraChangeListener
@IjzerenHein
Copy link
Contributor Author

Any chance we can get this pulled?

@marano
Copy link

marano commented Nov 18, 2017

Thank you this is great! It's a shame its not merged yet.

@christopherdro christopherdro merged commit ae228ae into react-native-maps:master Nov 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

onRegionChange is constantly called on Android after touching map
3 participants