Fixed crash caused by Android map lifecycle methods being called out of order. #1273
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We found an intermittent crash caused by
LifecycleEventListener.onHostResume
being called afterdoDestroy
. This caused an internal crash inMapView
, presumably due to itsonResume
method being called afteronDestroy
.Crash was as follows:
This PR also adds in previously missing
onStart
andonStop
calls: the docs expect the MapView to receive the lifecycle methods of its parent activity or fragment, and so we should try to replicate such a lifecycle as closely as possible with theAirMapView
.