Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS - Google Maps] Add showsMyLocationButton support #1157

Merged
merged 1 commit into from
Mar 26, 2017
Merged

[iOS - Google Maps] Add showsMyLocationButton support #1157

merged 1 commit into from
Mar 26, 2017

Conversation

davidstoker
Copy link
Contributor

Adds support for showsMyLocationButton property for iOS and Google Maps in the same way that it exists for Android.

screen shot 2017-03-22 at 19 06 16

@lelandrichardson lelandrichardson merged commit ae1dcc5 into react-native-maps:master Mar 26, 2017
@lelandrichardson
Copy link
Collaborator

Thanks!

@@ -12,7 +12,7 @@
| `customMapStyle` | `Array` | | Adds custom styling to the map component. See [README](https://github.com/airbnb/react-native-maps#customizing-the-map-style) for more information.
| `showsUserLocation` | `Boolean` | `false` | If `true` the app will ask for the user's location. **NOTE**: You need to add `NSLocationWhenInUseUsageDescription` key in Info.plist to enable geolocation, otherwise it is going to *fail silently*!
| `followsUserLocation` | `Boolean` | `false` | If `true` the map will focus on the user's location. This only works if `showsUserLocation` is true and the user has shared their location. **Note**: iOS only.
| `showsMyLocationButton` | `Boolean` | `true` | `Android only` If `false` hide the button to move map to the current user's location.
| `showsMyLocationButton` | `Boolean` | `true` | If `false` hide the button to move map to the current user's location.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to change this to Android or iOS with GoogleMaps provider only

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants