Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix onSelected event for markers with custom view #1079

Merged
merged 1 commit into from
Mar 26, 2017

Conversation

yonahforst
Copy link

@yonahforst yonahforst commented Mar 3, 2017

addresses #436, parts of #553

Problem: when using markers with a custom subview, didSelectAnnotation does not get triggered on tap events, unless you press on the outside edge of the marker (outside the subview but inside the marker)

Solution: 'marker-press' events manually call selectAnnotation on the marker's mapview

@yonahforst yonahforst changed the title addresses #436 fix marker onSelected events when using custom views Mar 3, 2017
@yonahforst yonahforst changed the title fix marker onSelected events when using custom views fix onSelected event for markers with custom view Mar 3, 2017
@lelandrichardson lelandrichardson merged commit 9f513ca into react-native-maps:master Mar 26, 2017
@lelandrichardson
Copy link
Collaborator

Thank you!

@leonardogutierrezh
Copy link

this creates an issue when you have multiple markers close together, the callout box jumps between the different markers

@switz
Copy link

switz commented Oct 19, 2019

Can this be hidden behind a flag? I believe it's causing multiple callouts to open on iOS when they're nearby.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants