Get outer DOM node from composite component wrapper #679
Conversation
| it('should return the outer most DOMComponent of the wrapper', () => { | ||
| const wrapper = mount(<Test />); | ||
| expect(wrapper.getDOMNode()).to.have.property('className', 'outer'); | ||
| }); |
There was a problem hiding this comment.
let's also add a test that grabs the inner DOM node, so we have one test for "root", one for "not root", and one for "throws on multiples"
| it('should return the outer most DOMComponent of the root wrapper', () => { | ||
| const wrapper = mount(<Test />); | ||
| expect(wrapper.getDOMNode()).to.have.property('className', 'outer'); | ||
| }); |
There was a problem hiding this comment.
nbd but let's make sure there's newlines between all the its :-)
|
One of travis CI processes failed relating to |
|
This also fixes #290 |
|
According to the React documentation findDOMNode can't be used on functional components, so this method cannot either. Two points:
|
|
Yes, i think we should add it as long as it throws when used on an SFC. |
| return this.single('getDOMNode', findDOMNode); | ||
| return this.single('getDOMNode', (n) => { | ||
| if (isFunctionalComponent(n)) { | ||
| throw new Error('Method “getDOMNode” cannot be used on functional components.'); |
There was a problem hiding this comment.
This should probably be a TypeError
christian-schulze
force-pushed
the
get-outer-dom-node-from-composite-component
branch
from
830b56e
to
27db1b0
Compare
|
I just learnt how to rebase/squash 👍 |
|
@christian-schulze awesome! it still looks like it's not rebased on latest master tho, fwiw. |
christian-schulze
force-pushed
the
get-outer-dom-node-from-composite-component
branch
from
27db1b0
to
e466a7f
Compare
|
@ljharb rebased from latest master |
|
@nfcampos et al; feel free to merge when you're ready |
christian-schulze
force-pushed
the
get-outer-dom-node-from-composite-component
branch
from
e466a7f
to
0d263bd
Compare
|
@christian-schulze would you mind rebasing before I merge this? |
christian-schulze
force-pushed
the
get-outer-dom-node-from-composite-component
branch
from
0d263bd
to
fd2939b
Compare
|
No worries @nfcampos, rebased |
|
Thanks @christian-schulze! will merge as soon as build passes on travis :) |
|
@nfcampos Build is green ✅ |
|
Merged, thanks! |
As outlined in #623 and #446, implement
ReactWrapper#getDOMNodewhich provides access to the outer most DOMComponent of a mounted composite component.If you are happy for this to exist, I will add api documentation.