Match children before and after interpolation #512
Conversation
|
I think this LGTM, pending another contrib's OK, and a rebase. |
|
I'm not sure yet if this is a patch or a minor. |
|
Probably better to be on a safe side by making it a minor version instead of a patch. |
|
That's not really safer, since neither is supposed to have a breaking change :-) |
|
Ah, that came out wrong. I was thinking of a versioning scenario that doesn't apply here and in the case where it does cause a breaking change accidentally by slipping through existing tests. Flip a coin or use your best judgement then. ;) |
src/Utils.js
Outdated
|
|
||
| for (let i = 0; i < childrenArray.length; i++) { | ||
| const child = childrenArray[i]; | ||
| const simplifiedChild = simplifiedArray.pop(); |
There was a problem hiding this comment.
how about calling this previousChild?
|
@ljharb if we define majors for enzyme as 'some tests that passed/failed with the previous version now will, respectively, fail/pass' then this is a major. if not it's a patch I think |
|
LGTM pending my minor comments being addressed |
|
@nfcampos it's a minor if it's a new feature, but that suggests it's an intentional change which makes tests have different results, which makes it major. If tests were never supposed to have the current results and this fixes it, it's a patch. So, as you say - just very fuzzy :-/ |
eronisko
force-pushed
the
interpolated_children
branch
from
89695f9
to
106c89e
Compare
|
LGTM after the changes, now we just need to decide on what kind of change this is |
|
Has there been any consensus on whether to release this under minor, major or patch release? |
|
@eronisko are you able to rebase this on top of latest master? it'd be great to get this in. |
eronisko
force-pushed
the
interpolated_children
branch
from
298bd6c
to
58820e0
Compare
|
@ljharb done |
Proposed fix for #508.