Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add key method #327

Merged
merged 1 commit into from
Apr 17, 2016
Merged

Add key method #327

merged 1 commit into from
Apr 17, 2016

Conversation

SimenB
Copy link
Contributor

@SimenB SimenB commented Apr 17, 2016

No description provided.

}

/**
* Returns the type of the root node of this wrapper. If it's a composite component, this will be
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo (ndoe => node)

@ljharb
Copy link
Member

ljharb commented Apr 17, 2016

Does .prop('key') not give you the same information?

@SimenB
Copy link
Contributor Author

SimenB commented Apr 17, 2016

Nope, it's not included in props.

It's not included in react test utils' shallow render's props either, it's attached to the node itself (like in enzyme)

@ljharb
Copy link
Member

ljharb commented Apr 17, 2016

in that case, awesome - pending typo corrections this LGTM

@SimenB
Copy link
Contributor Author

SimenB commented Apr 17, 2016

👍

Did I make a typo? (Current) typo comment is mine, just pointing out why that line changed in the diff

@ljharb
Copy link
Member

ljharb commented Apr 17, 2016

@SimenB oh oops, i didn't realize - nope, you're good then

@ljharb ljharb merged commit 1b9d317 into enzymejs:master Apr 17, 2016
@ljharb
Copy link
Member

ljharb commented Apr 17, 2016

Thanks!

@SimenB SimenB deleted the key branch April 17, 2016 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants