Change ShallowWrapper.text() trim spaces with same behavior as ReactWrapper.text() #1350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
reviewed
Nov 13, 2017
| @@ -1633,6 +1633,29 @@ describe('shallow', () => { | |||
| matchesRender(<div>></div>); | |||
| }); | |||
|
|
|||
| it('should handle spaces with same behavior as ReactWarpper.text()', () => { | |||
There was a problem hiding this comment.
ReactWarpper.text → ReactWrapper.text
|
In the end ReactWrapper.text() don't do anything to spaces, so the solution was to remove the |
ljharb
requested review from
nfcampos,
lelandrichardson,
blainekasten,
aweary and
a team
aweary
approved these changes
Nov 13, 2017
ljharb
approved these changes
Nov 13, 2017
|
@idanilt would you mind rebasing this on latest master? |
added 3 commits
November 14, 2017 15:11
…rapper.text() - remove empty nodes - remove double spaces - remove spaces from beginning or end - not sure all those are all the rule, need to check - couldn't run tests
…ny spaces); fix env on Windows;
This was referenced Nov 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ReactWrapper.text() return string with the spaces as is, ShallowWrapper.text() removing double spaces and replacing with regular space (removing doubles as well).
Fixes #1349.